Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move doctrine migrations away from src #718

Closed
ro0NL opened this issue Jan 3, 2020 · 7 comments · Fixed by #729
Closed

move doctrine migrations away from src #718

ro0NL opened this issue Jan 3, 2020 · 7 comments · Fixed by #729

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Jan 3, 2020

it was briefly discussed here #172 (comment), but seems to be ignored eventually

i like to propose to move src/Migrations to migrations/. I dont understand why we are moving mountains to keep it in src (extra config etc.) :/ is there any technical blocker to not move it away from src?

semantically it does not belong in src IMHO.

(https://www.tomasvotruba.cz/blog/2019/12/23/5-things-i-improve-when-i-get-to-new-repository/#3-move-code-to-src)

@ogizanagi
Copy link
Member

I'm already doing this for all of my projects. So 👍 from me.

@ro0NL
Copy link
Contributor Author

ro0NL commented Jan 10, 2020

alternatively to introduce a more generic/reusable directory in our landscape: ./scripts/database-migrations/? But im not sure it's valid UNIX style let's say.

We should carefully think about root directories though, at some point it gets out of control.

@ogizanagi
Copy link
Member

ogizanagi commented Jan 10, 2020

The more generic/reusable proposition was made a long-time ago, but without enough traction/consensus to happen: a res directory which would contain any resources used by the app, i.e:

  • migrations
  • assets
  • fixtures
  • templates
  • docs
  • translations
  • ...

@ro0NL
Copy link
Contributor Author

ro0NL commented Jan 10, 2020

i like res 😍 can we do that? please? 😁

@yceruto
Copy link
Member

yceruto commented Jan 10, 2020

I like migrations/ at the root too 👍

@ro0NL
Copy link
Contributor Author

ro0NL commented Jan 10, 2020

@javiereguiluz ive reread the issue real quick, fair enough :) the ship has sailed. I still think it's more concise in general, but 👍 for many root dirs tied to SF, in a SF specific project dir.

@dmaicher
Copy link
Contributor

javiereguiluz added a commit to symfony/demo that referenced this issue Jun 11, 2020
This PR was merged into the master branch.

Discussion
----------

Move doctrine migrations away from src

Related to symfony/recipes#718

Commits
-------

10d3324 Move doctrine migrations away from src
sayjun0505 added a commit to sayjun0505/sym_proj that referenced this issue Apr 16, 2023
This PR was merged into the master branch.

Discussion
----------

Move doctrine migrations away from src

Related to symfony/recipes#718

Commits
-------

10d3324 Move doctrine migrations away from src
mwhorse46 added a commit to mwhorse46/sym_proj that referenced this issue Apr 16, 2023
This PR was merged into the master branch.

Discussion
----------

Move doctrine migrations away from src

Related to symfony/recipes#718

Commits
-------

10d3324 Move doctrine migrations away from src
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants