[fw-bundle] Add support for validator auto-mapping #559

dunglas · 2019-03-31T21:48:03Z

Q	A
License	MIT

Enables symfony/symfony#27735 by default.

ghost

Pull request passes validation.

symfony/framework-bundle/4.3/config/bootstrap.php

weaverryan · 2019-04-09T04:35:54Z

symfony/framework-bundle/4.3/config/packages/framework.yaml

+        # Enables validator auto-mapping support.
+        # For instance, basic validation constraints will be inferred from Doctrine's metadata.
+        auto_mapping:
+            App\Entity\: []


I keep thinking that this might make more sense as an annotation o the class not here. Currently, I look at my class to find all my constraints. Now I will possibly have these “silent” constraints I can’t track down. Could we activate the auto-constraints... with a constraint? We could generate entities with this by default with make:entity.

I know, wrong place to discuss - I just didn’t make it in time to the original Pr.

This is a config which applies to all entities in given namespace, not specific class. How would you do that with annotation? Where would you put such annotation?

This config supports setting full namespaces, as here, but also a list of specific classes using the glob syntax.
There is no annotations because it’s a bundle config. Only XML and YAML are supported. It’s similar to the service discovery config.

And in almost all cases, it’s safer to always enable autovalidation. If it triggers a false positive, it’s most likely because the user is doing something very wrong that should be fixed.

ghost

Pull request does not pass validation.

dunglas · 2019-05-09T16:16:46Z

Recipe updated to use symlinks. Is it ok to use symlinks for whole directories too? (It's why the check is red right now).

I tested it with 4.3 beta and DoctrineBundle master, and it works as expected.

nicolas-grekas · 2019-05-09T16:24:03Z

Is it ok to use symlinks for whole directories too? (It's why the check is red right now).

Yes conceptually, no technically apparently :) @fabpot can we adapt the check?

fabpot · 2019-05-10T08:57:18Z

@symfony-flex-server review

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request passes validation.

fabpot · 2019-05-10T11:24:54Z

@symfony-flex-server review

ghost

Pull request passes validation.

fabpot · 2019-05-10T11:25:26Z

@dunglas @nicolas-grekas Flex server fixed, recipe is green, BUT you should test it to be sure that it works correctly.

dunglas · 2019-05-11T07:43:21Z

On my machine (Mac OS 10.14), symlinked files are not created during composer create-project, even for the current stable version.

Reproducer:

$ composer create-project symfony/skeleton testsf42
$ ls -a testsf42/config/packages/
dev            framework.yaml routing.yaml   test

cache.yaml hasn't been generated.

nicolas-grekas · 2019-05-11T07:59:40Z

I confirm the issue: a project created a few days ago contains config/packages/cache.yaml while a new one created now doesn't.

fabpot · 2019-05-11T09:27:23Z

Problem with symlinked files is fixed now.

fabpot · 2019-05-11T09:31:22Z

And this PR seems to work fine. @dunglas Can you confirm?

symfony/framework-bundle/4.3/config/packages/framework.yaml

ghost

Pull request passes validation.

dunglas · 2019-05-11T09:57:21Z

Good idea. It's where this config belongs. Updated.

dunglas · 2019-05-11T10:03:09Z

And I confirm this PR works as expected!

ghost deployed to staging March 31, 2019 21:48 View deployment

ghost approved these changes Mar 31, 2019

View reviewed changes

maxhelias approved these changes Apr 1, 2019

View reviewed changes

Pierstoval approved these changes Apr 1, 2019

View reviewed changes

teohhanhui reviewed Apr 1, 2019

View reviewed changes

symfony/framework-bundle/4.3/config/bootstrap.php Outdated Show resolved Hide resolved

weaverryan reviewed Apr 9, 2019

View reviewed changes

dunglas added 2 commits May 9, 2019 18:08

[fw-bundle] Add support for validator auto-mapping

685e9eb

Use symlinks

5fa21eb

dunglas force-pushed the validator-automapping branch from 2eafd3c to 5fa21eb Compare May 9, 2019 16:14

ghost suggested changes May 9, 2019

View reviewed changes

ghost suggested changes May 10, 2019

View reviewed changes

ghost deployed to staging May 10, 2019 11:19 View deployment

ghost approved these changes May 10, 2019

View reviewed changes

ghost deployed to staging May 10, 2019 11:24 View deployment

ghost approved these changes May 10, 2019

View reviewed changes

fabpot requested changes May 11, 2019

View reviewed changes

symfony/framework-bundle/4.3/config/packages/framework.yaml Outdated Show resolved Hide resolved

Move the config to the validator recipe

32dd187

ghost deployed to staging May 11, 2019 09:56 View deployment

ghost approved these changes May 11, 2019

View reviewed changes

fabpot approved these changes May 11, 2019

View reviewed changes

maxhelias approved these changes May 11, 2019

View reviewed changes

nicolas-grekas approved these changes May 12, 2019

View reviewed changes

ghost merged commit 32dd187 into symfony:master May 12, 2019

ghost pushed a commit that referenced this pull request May 12, 2019

Merge pull request #559

3b19bd9

soyuka mentioned this pull request Aug 2, 2019

Automatic validation may cause issues with fields that are generated api-platform/api-platform#1211

Open

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fw-bundle] Add support for validator auto-mapping #559

[fw-bundle] Add support for validator auto-mapping #559

dunglas commented Mar 31, 2019

ghost left a comment

weaverryan Apr 9, 2019

ostrolucky Apr 19, 2019

dunglas Apr 20, 2019

dunglas Apr 20, 2019

ghost left a comment

dunglas commented May 9, 2019

nicolas-grekas commented May 9, 2019

fabpot commented May 10, 2019

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

fabpot commented May 10, 2019

ghost left a comment

fabpot commented May 10, 2019

dunglas commented May 11, 2019

nicolas-grekas commented May 11, 2019

fabpot commented May 11, 2019

fabpot commented May 11, 2019

ghost left a comment

dunglas commented May 11, 2019

dunglas commented May 11, 2019

[fw-bundle] Add support for validator auto-mapping #559

[fw-bundle] Add support for validator auto-mapping #559

Conversation

dunglas commented Mar 31, 2019

ghost left a comment

Choose a reason for hiding this comment

weaverryan Apr 9, 2019

Choose a reason for hiding this comment

ostrolucky Apr 19, 2019

Choose a reason for hiding this comment

dunglas Apr 20, 2019

Choose a reason for hiding this comment

dunglas Apr 20, 2019

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

dunglas commented May 9, 2019

nicolas-grekas commented May 9, 2019

fabpot commented May 10, 2019

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

fabpot commented May 10, 2019

ghost left a comment

Choose a reason for hiding this comment

fabpot commented May 10, 2019

dunglas commented May 11, 2019

nicolas-grekas commented May 11, 2019

fabpot commented May 11, 2019

fabpot commented May 11, 2019

ghost left a comment

Choose a reason for hiding this comment

dunglas commented May 11, 2019

dunglas commented May 11, 2019