[doctrine/doctrine-bundle] dont duplicate the db settings #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
Pierstoval
reviewed
Nov 13, 2019
nicolas-grekas
commented
Nov 13, 2019
| charset: utf8mb4 | ||
| default_table_options: | ||
| charset: utf8mb4 |
There was a problem hiding this comment.
this one is not needed, the above charset is copied here by default already
that's why the comments are needed - for these setups (SFCloud sets the option |
yceruto
reviewed
Nov 13, 2019
yceruto
approved these changes
Nov 13, 2019
fabpot
approved these changes
Nov 13, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent hours of debugging because the db driver was set differently in two places: the yaml and the .env files.
Actually, we don't need the duplication at all. Let's favor the
.envsince it is now always loaded.