Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHP to define the services and routes of the app #765

Closed
wants to merge 1 commit into from
Closed

Use PHP to define the services and routes of the app #765

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT
Doc issue/PR -

This is #721 again, after it's been reverted in #750.
Let's build a plan to make this happen smoothly.

ghost
ghost approved these changes Apr 25, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan weaverryan mentioned this pull request Jun 12, 2020
Merged
@nicolas-grekas nicolas-grekas deleted the php-dsl branch January 15, 2021 15:03
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 15, 2021
Closed
@nicolas-grekas
Copy link
Member Author

I've realized we can drop the services and routes files entirely! See #872

@nicolas-grekas nicolas-grekas mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nicolas-grekas