Tweaking phpunit post-install message to give more information/context #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
This is because, it *does* look a little odd to remove phpunit/phpunit and require phpunit. This is more descriptive
fabpot
approved these changes
Aug 19, 2020
maxhelias
approved these changes
Aug 19, 2020
ogizanagi
approved these changes
Aug 19, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous message appears to some people like Symfony is trying to "force" people what to do or to replace PHPUnit.
In reality, the goal is to make sure the user is aware that - to follow the "documented path" - the bridge is available. But if they still want to install PHPUnit, that's totally fine.
Related to: symfony/symfony#27289 and https://twitter.com/Ocramius/status/1293169839582973952