Remove support for Behat Sf Extension #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem here is that the symfony extension for behat is not maintained and not compatible with new versions of Symfony. It has been officialized here: Behat/Symfony2Extension#152 (comment) The new correct way to use behat with Symfony is to use the package symfony extension from the FriendsOfBehat organization. - https://github.com/FriendsOfBehat/SymfonyExtension - https://github.com/symfony/recipes-contrib/tree/master/friends-of-behat/symfony-extension/2.0
ghost
deployed
to
nicolas-grekas
approved these changes
Oct 7, 2020
|
Should we move it to recipes-contrib? Can you please do the PR if yes? |
|
@nicolas-grekas no, it should just not exist. It already exists a recipe for the correct package to use. Even Google suggests the good one first.
|
chalasr
approved these changes
Oct 21, 2020
|
Btw, I think we should change the behat alias to the new Friends of Behat package and include those recipes in this repository. I'm happy to provide the move PR if this is supported, not sure how to add the behat alias. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that the Symfony extension for Behat is not maintained and not compatible with new versions of Symfony. It has been officialized here:
Behat/Symfony2Extension#152 (comment)
The new correct way to use Behat with Symfony is to use the package Symfony extension from the FriendsOfBehat organization.
Oh and btw if you merge it you can add the
hacktoberfest-acceptedlabel :) .