Moving scripts to <head> by default #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With <script defer, execution is still done after page load, but is more performant and works will with Turbo
ghost
deployed
to
dunglas
approved these changes
Jan 15, 2021
nicolas-grekas
approved these changes
Jan 15, 2021
|
Besides the docs and videos, it also has a big impact (like any recipe change that does not target the next Symfony version) on the book. I've mentioned that in the past, but I think we should not make such changes in past version and limit them to the next minor version. |
|
I forgot to mention that it also makes some blog posts not working anymore. If one tries to follow the book examples, the patches won't apply cleanly anymore. That should not happen IMHO. We should not break the past. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 17, 2021
…hange (weaverryan)
This PR was merged into the 4.4 branch.
Discussion
----------
Updating {% block javascripts position to match recipe change
Hi!
See symfony/recipes#874
I did this against 4.4 (which is normally done for bug fixes) because this *would* appear as a "documentation bug" if we updated the recipe but didn't update the docs.
Thanks!
Commits
-------
8c2c794 Updating {% block javascripts position to match recipe change
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is "kind of" a big change from a documentation POV, though the docs PR to update things was very small (and I'll check SymfonyCasts for any notes needed).
Having
scripttags in theheadis more performant (and works well with Turbo) AND has the same behavior as putting the scripts at the bottom as long as you use<script defer. In WebpackEncore 1.9, you can now specify to adddeferautomatically on all script tags and the new 1.9 recipe enables this by defaultSo, things should "just work" like before, but some docs will need to be updated.
TODO