Set display_errors for phpunit #888

BackEndTea · 2021-02-05T08:37:38Z

Q	A
License	MIT
Doc issue/PR	N/A

When phpunit runs into an error, with display_errors set to 0, you will not see any output, and phpunit will just exit. This is somewhat of a misconfiguration for a dev env, but i've ran into this a few times. By forcing display_errors to 1, you will get an error output, which may point you into the right direction.

I've opted to add this to all versions, instead of from the newest version, as the difference is minimal, and shouldn't be too confusing when tutorials etc may show an older version.

ghost

Pull request passes validation.

nicolas-grekas · 2021-02-05T16:11:02Z

I've never experienced this issue even though I have display_errors=0. When does this make a difference? Can you provide a small app to see this?

BackEndTea · 2021-02-05T19:57:20Z

Took me a bit to figure out what went wrong originally. The issue is that you don't get any error output when both display_errors is off, and log_errors is off. If either one is on you should get a message.

Example with a class making a static method non static (any php script that produces an error is fine):

<?php
//foo.php 
class One
{
    public static function foo()
    {

    }
}

class Two extends One
{
    public function foo()
    {

    }
}

echo "============================"
echo "1 display, 1 log"
php -ddisplay_errors=1 -dlog_errors=1 foo.php
echo "done"
echo "============================"
echo "0 display, 1 log"
php -ddisplay_errors=0 -dlog_errors=1 foo.php
echo "done"
echo "============================"
echo "1 dislay 0 log"
php -ddisplay_errors=1 -dlog_errors=0 foo.php
echo "done"
echo "============================"
echo "0 dislay 0 log"
php -ddisplay_errors=0 -dlog_errors=0 foo.php
echo "done"
echo "============================"

$ bash run.sh
============================
1 display, 1 log
PHP Fatal error:  Cannot make static method One::foo() non static in class Two in /var/www/foo.php on line 13

Fatal error: Cannot make static method One::foo() non static in class Two in /var/www/foo.php on line 13
done
============================
0 display, 1 log
PHP Fatal error:  Cannot make static method One::foo() non static in class Two in /var/www/foo.php on line 13
done
============================
1 dislay 0 log

Fatal error: Cannot make static method One::foo() non static in class Two in /var/www/foo.php on line 13
done
============================
0 dislay 0 log
done
============================

Note that the last one has no error output.

nicolas-grekas · 2021-07-10T09:11:57Z

(please rebase so that the new checks can run)

ghost

Pull request passes validation.

github-actions · 2021-07-12T06:15:50Z

Diff between recipe versions

Thanks for the PR 😍

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

phpunit/phpunit

4.7 vs 9.3

diff --git a/phpunit/phpunit/4.7/phpunit.xml.dist b/phpunit/phpunit/9.3/phpunit.xml.dist
index 5e90897..af3f147 100644
--- a/phpunit/phpunit/4.7/phpunit.xml.dist
+++ b/phpunit/phpunit/9.3/phpunit.xml.dist
@@ -6,12 +6,15 @@
          backupGlobals="false"
          colors="true"
          bootstrap="tests/bootstrap.php"
+         convertDeprecationsToExceptions="false"
 >
     <php>
         <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
+        <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="9.5" />
     </php>
 
     <testsuites>
@@ -20,11 +23,11 @@
         </testsuite>
     </testsuites>
 
-    <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
+    <coverage processUncoveredFiles="true">
+        <include>
             <directory suffix=".php">src</directory>
-        </whitelist>
-    </filter>
+        </include>
+    </coverage>
 
     <listeners>
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />

symfony/phpunit-bridge

3.3 vs 4.1

diff --git a/symfony/phpunit-bridge/3.3/.env.test b/symfony/phpunit-bridge/4.1/.env.test
index 24a43c0..9e7162f 100644
--- a/symfony/phpunit-bridge/3.3/.env.test
+++ b/symfony/phpunit-bridge/4.1/.env.test
@@ -2,3 +2,5 @@
 KERNEL_CLASS='App\Kernel'
 APP_SECRET='$ecretf0rt3st'
 SYMFONY_DEPRECATIONS_HELPER=999999
+PANTHER_APP_ENV=panther
+PANTHER_ERROR_SCREENSHOT_DIR=./var/error-screenshots
diff --git a/symfony/phpunit-bridge/3.3/bin/phpunit b/symfony/phpunit-bridge/4.1/bin/phpunit
index 0b79fd4..63dae24 100755
--- a/symfony/phpunit-bridge/3.3/bin/phpunit
+++ b/symfony/phpunit-bridge/4.1/bin/phpunit
@@ -6,12 +6,6 @@ if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-php
     exit(1);
 }
 
-if (false === getenv('SYMFONY_PHPUNIT_VERSION')) {
-    putenv('SYMFONY_PHPUNIT_VERSION=6.5');
-}
-if (false === getenv('SYMFONY_PHPUNIT_REMOVE')) {
-    putenv('SYMFONY_PHPUNIT_REMOVE=symfony/yaml');
-}
 if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
     putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
 }
diff --git a/symfony/phpunit-bridge/3.3/phpunit.xml.dist b/symfony/phpunit-bridge/4.1/phpunit.xml.dist
index 294a559..d81f0c3 100644
--- a/symfony/phpunit-bridge/3.3/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/4.1/phpunit.xml.dist
@@ -8,10 +8,11 @@
          bootstrap="tests/bootstrap.php"
 >
     <php>
-        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
+        <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="7.5" />
     </php>
 
     <testsuites>
@@ -21,8 +22,8 @@
     </testsuites>
 
     <filter>
-        <whitelist>
-            <directory>src</directory>
+        <whitelist processUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">src</directory>
         </whitelist>
     </filter>

4.1 vs 4.3

diff --git a/symfony/phpunit-bridge/4.1/bin/phpunit b/symfony/phpunit-bridge/4.3/bin/phpunit
index 63dae24..4d1ed05 100755
--- a/symfony/phpunit-bridge/4.1/bin/phpunit
+++ b/symfony/phpunit-bridge/4.3/bin/phpunit
@@ -1,8 +1,8 @@
 #!/usr/bin/env php
 <?php
 
-if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit')) {
-    echo "Unable to find the `simple-phpunit` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
+if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php')) {
+    echo "Unable to find the `simple-phpunit.php` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
     exit(1);
 }
 
@@ -10,4 +10,4 @@ if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
     putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
 }
 
-require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit';
+require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php';
diff --git a/symfony/phpunit-bridge/4.1/phpunit.xml.dist b/symfony/phpunit-bridge/4.3/phpunit.xml.dist
index d81f0c3..5766779 100644
--- a/symfony/phpunit-bridge/4.1/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/4.3/phpunit.xml.dist
@@ -8,6 +8,7 @@
          bootstrap="tests/bootstrap.php"
 >
     <php>
+        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />

4.3 vs 5.1

diff --git a/symfony/phpunit-bridge/4.3/phpunit.xml.dist b/symfony/phpunit-bridge/5.1/phpunit.xml.dist
index 5766779..0bd20c8 100644
--- a/symfony/phpunit-bridge/4.3/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/5.1/phpunit.xml.dist
@@ -8,12 +8,11 @@
          bootstrap="tests/bootstrap.php"
 >
     <php>
-        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
         <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
-        <server name="SYMFONY_PHPUNIT_VERSION" value="7.5" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="8.5" />
     </php>
 
     <testsuites>
@@ -31,4 +30,11 @@
     <listeners>
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
     </listeners>
+
+    <!-- Run `composer require symfony/panther` before enabling this extension -->
+    <!--
+    <extensions>
+        <extension class="Symfony\Component\Panther\ServerExtension" />
+    </extensions>
+    -->
 </phpunit>

5.1 vs 5.3

diff --git a/symfony/phpunit-bridge/5.1/bin/phpunit b/symfony/phpunit-bridge/5.3/bin/phpunit
index 4d1ed05..f26f2c7 100755
--- a/symfony/phpunit-bridge/5.1/bin/phpunit
+++ b/symfony/phpunit-bridge/5.3/bin/phpunit
@@ -1,13 +1,19 @@
 #!/usr/bin/env php
 <?php
 
-if (!file_exists(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php')) {
-    echo "Unable to find the `simple-phpunit.php` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
-    exit(1);
+if (!ini_get('date.timezone')) {
+    ini_set('date.timezone', 'UTC');
 }
 
-if (false === getenv('SYMFONY_PHPUNIT_DIR')) {
-    putenv('SYMFONY_PHPUNIT_DIR='.__DIR__.'/.phpunit');
-}
+if (is_file(dirname(__DIR__).'/vendor/phpunit/phpunit/phpunit')) {
+    define('PHPUNIT_COMPOSER_INSTALL', dirname(__DIR__).'/vendor/autoload.php');
+    require PHPUNIT_COMPOSER_INSTALL;
+    PHPUnit\TextUI\Command::main();
+} else {
+    if (!is_file(dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php')) {
+        echo "Unable to find the `simple-phpunit.php` script in `vendor/symfony/phpunit-bridge/bin/`.\n";
+        exit(1);
+    }
 
-require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php';
+    require dirname(__DIR__).'/vendor/symfony/phpunit-bridge/bin/simple-phpunit.php';
+}
diff --git a/symfony/phpunit-bridge/5.1/manifest.json b/symfony/phpunit-bridge/5.3/manifest.json
index a2ed0cb..4fb292b 100644
--- a/symfony/phpunit-bridge/5.1/manifest.json
+++ b/symfony/phpunit-bridge/5.3/manifest.json
@@ -6,7 +6,6 @@
         "tests/": "tests/"
     },
     "gitignore": [
-        ".phpunit",
         ".phpunit.result.cache",
         "/phpunit.xml"
     ],
diff --git a/symfony/phpunit-bridge/5.1/phpunit.xml.dist b/symfony/phpunit-bridge/5.3/phpunit.xml.dist
index 0bd20c8..af3f147 100644
--- a/symfony/phpunit-bridge/5.1/phpunit.xml.dist
+++ b/symfony/phpunit-bridge/5.3/phpunit.xml.dist
@@ -2,17 +2,19 @@
 
 <!-- https://phpunit.readthedocs.io/en/latest/configuration.html -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="bin/.phpunit/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          backupGlobals="false"
          colors="true"
          bootstrap="tests/bootstrap.php"
+         convertDeprecationsToExceptions="false"
 >
     <php>
+        <ini name="display_errors" value="1" />
         <ini name="error_reporting" value="-1" />
         <server name="APP_ENV" value="test" force="true" />
         <server name="SHELL_VERBOSITY" value="-1" />
         <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
-        <server name="SYMFONY_PHPUNIT_VERSION" value="8.5" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="9.5" />
     </php>
 
     <testsuites>
@@ -21,11 +23,11 @@
         </testsuite>
     </testsuites>
 
-    <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
+    <coverage processUncoveredFiles="true">
+        <include>
             <directory suffix=".php">src</directory>
-        </whitelist>
-    </filter>
+        </include>
+    </coverage>
 
     <listeners>
         <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
diff --git a/symfony/phpunit-bridge/5.1/post-install.txt b/symfony/phpunit-bridge/5.3/post-install.txt
index 6dd929f..7bb1532 100644
--- a/symfony/phpunit-bridge/5.1/post-install.txt
+++ b/symfony/phpunit-bridge/5.3/post-install.txt
@@ -3,4 +3,5 @@
               
 
   * Write test cases in the tests/ folder
-  * Run php bin/phpunit
+  * Use MakerBundle's make:test command as a shortcut!
+  * Run the tests with php bin/phpunit

BackEndTea · 2021-07-12T06:16:01Z

rebased

ghost

Pull request passes validation.

nicolas-grekas · 2021-07-12T13:29:48Z

Maybe we can update only the latest of each major?

ghost

Pull request passes validation.

ghost deployed to staging February 5, 2021 08:37 View deployment

ghost approved these changes Feb 5, 2021

View reviewed changes

nicolas-grekas force-pushed the master branch from 735eca4 to b570dde Compare July 7, 2021 14:11

BackEndTea force-pushed the feat/display_errors branch from 91128f0 to 287d665 Compare July 12, 2021 06:15

ghost deployed to staging July 12, 2021 06:15 View deployment

ghost approved these changes Jul 12, 2021

View reviewed changes

Set display_errors for phpunit

60d9dd6

BackEndTea force-pushed the feat/display_errors branch from 287d665 to 60d9dd6 Compare July 12, 2021 06:18

ghost deployed to staging July 12, 2021 06:18 View deployment

ghost approved these changes Jul 12, 2021

View reviewed changes

Only set display_errors in latest version of major

df4228b

ghost deployed to staging July 12, 2021 13:46 View deployment

ghost approved these changes Jul 12, 2021

View reviewed changes

nicolas-grekas approved these changes Jul 12, 2021

View reviewed changes

derrabus approved these changes Jul 12, 2021

View reviewed changes

ghost merged commit 0728692 into symfony:master Jul 12, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set display_errors for phpunit #888

Set display_errors for phpunit #888

BackEndTea commented Feb 5, 2021

ghost left a comment

nicolas-grekas commented Feb 5, 2021

BackEndTea commented Feb 5, 2021

nicolas-grekas commented Jul 10, 2021

ghost left a comment

github-actions bot commented Jul 12, 2021 •

edited

BackEndTea commented Jul 12, 2021

ghost left a comment

nicolas-grekas commented Jul 12, 2021 •

edited

ghost left a comment

Set display_errors for phpunit #888

Set display_errors for phpunit #888

Conversation

BackEndTea commented Feb 5, 2021

ghost left a comment

Choose a reason for hiding this comment

nicolas-grekas commented Feb 5, 2021

BackEndTea commented Feb 5, 2021

nicolas-grekas commented Jul 10, 2021

ghost left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 12, 2021 • edited

Diff between recipe versions

phpunit/phpunit

symfony/phpunit-bridge

BackEndTea commented Jul 12, 2021

ghost left a comment

Choose a reason for hiding this comment

nicolas-grekas commented Jul 12, 2021 • edited

ghost left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 12, 2021 •

edited

nicolas-grekas commented Jul 12, 2021 •

edited