Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support psr/container 2 #2

Closed
wants to merge 1 commit into from
Closed

Conversation

othercorey
Copy link

We're hoping the 2.4/2.5 release can support psr/container 2 since it should be BC with 1.1.

https://github.com/php-fig/container/releases/tag/2.0.0

The only change is an added return type. Other projects are switching to psr/container and depending tend to his this package.

@symfony-bot
Copy link

symfony-bot bot commented Oct 24, 2021

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony contracts repository. It is used by Composer to allow developers to depend on specific Symfony contracts.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/contracts

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the main branch.

@othercorey othercorey closed this Oct 24, 2021
@othercorey othercorey deleted the patch-1 branch October 24, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant