This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Adapt collector template name to webprofiler conventions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | fabpot/Twig#1156 | License | MIT Debugging the issue I noticed that the @WebProfiler templates use a different convention than the @SecurityBundle collector template. This is a quick fix. To allow the conventions most bundles use the Twig_Loader_Filesystem needs to be updated instead.
fabpot
added a commit
that referenced
this pull request
Aug 5, 2013
This PR was merged into the master branch. Discussion ---------- Adapt collector template name to webprofiler conventions | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | fabpot/Twig#1156 | License | MIT Debugging the issue I noticed that the @WebProfiler templates use a different convention. This is a quick fix. To allow the conventions most bundles use the Twig_Loader_Filesystem needs to be updated instead. Commits ------- 1a05027 Adapt collector template name to webprofiler conventions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging the issue I noticed that the @WebProfiler templates use a different convention.
This is a quick fix.
To allow the conventions most bundles use the Twig_Loader_Filesystem needs to be updated instead.