Add docker support

[dosten]

Hi!

This PR adds Docker support, so, anyone with a Docker installation can run $ docker-compose up to run the application :)

[javiereguiluz]

@dosten thanks for sending this improvement. Before merging it, I'll wait for someone with Docker experience to review it. Thanks.

[mykiwi]

I'm agree to add docker.

I think it will be nicer if Dockerfiles files were in a docker (or .docker) directory.

I use a different Dockerfile to have no warning/error while running app/check.php, and also use the port 80:

FROM php:5.6

RUN apt-get update && \
    apt-get install -y libicu-dev g++ && \
    docker-php-ext-install intl mbstring opcache && \
    apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* && \
    echo "date.timezone = UTC\nshort_open_tag=Off" >> /usr/local/etc/php/conf.d/symfony.ini

VOLUME  /srv
WORKDIR /srv

EXPOSE 80

ENTRYPOINT ["app/console"]
CMD ["server:run", "0.0.0.0:80"]

In the readme, we should also explain how use the app/console with docker-compose:
docker-compose run --rm web app/console

And maybe we should rename the web service (in docker-compose.yml) by symfony.

[javiereguiluz]

@romqin thanks for proposing this alternative! Now I'll wait for other Docker users to comment about which is the best file to use and about @romqin's idea to create a docker directory. Thanks.

[bocharsky-bw]

The Mac users may have problems to use it (there are permissions problem for cache dir that not fixed yet, only workaround exists now).
I think the best solution is to use Vagrant with NFS files sharing to avoid it, but that way we get possible problems with Windows users because they haven't NFS sharing.

So I don't think that add Docker is a good idea, it will not be cross platform because there are a lot of custom solutions and workaround for different OS.

[mykiwi]

@bocharsky-bw I'm on Mac and I don't have this problems. You can set the option -u with the user uid.
Kitematic (or boot2docker, but less user friendly) should works fine for windows.

[bocharsky-bw]

@romqin Do you think it will be a right solution? It all will be need to add to docs, it's too specific for separate OS. And what about Windows users?

Anyway I vote to move this Docker solution to the separate repository as it too specific as for me.

[Nicofuma]

For the cache and logs, what we can do is to add a volume container to hold them. This way we will not have any perm issue (but if you want to see the logs you will have to use docker exec)

EDIT: actually no need for another container, just define the volumes (see @jderusse comment below)

[jderusse]

Please, use the default http port 80, if the end user want to map it with something else, he can do it with -p 8000:80

[bocharsky-bw]

I vote for 8000 port because it used as a default port for app/console server:run command.

[jderusse]

server:run is designed to run on the developer's machine which probably have an other webserver listening on port 80.
This issue does not exists in a containers.

[bocharsky-bw]

Yes, it makes sense. However, I think almost every developer should change 80 to something different because he most probably also has an installed server which already listening 80 on host machine. So maybe better left 8000 for container?

[mykiwi]

I also think that the server should be run on port 80. If it is already used on the host, the port must be changed in the docker-compose.yml

[jderusse]

Some developpers don't use the port forwarding to the Host.
But use DNS to directly access the container. It will be great to use the default port.

[killerwolf]

Is the Dockerfile for demo or dev purposes ?

[javiereguiluz]

Do you think it's possible to agree on some common Docker configuration to merge this? Thanks!

[bocharsky-bw]

I plan to use Dockerfile for dev purpose too.

[mykiwi]

I would prefer this:

RUN echo "date.timezone = UTC"  >> /usr/local/etc/php/conf.d/symfony.ini && \
    echo "short_open_tag = off" >> /usr/local/etc/php/conf.d/symfony.ini && \
    apt-get update && \
    apt-get install -y libicu-dev && \
    docker-php-ext-install intl mbstring opcache && \
    apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

It's for the app/check.php and also to add opcache

[bocharsky-bw]

I suppose that libicu-dev needs for intl, right? But why we need g++ here?

[mykiwi]

Indeed. g++ is not required, I removed it.

[bocharsky-bw]

What about xdebug? Could we install it here?

[jderusse]

👎

[bocharsky-bw]

What about to create docker/php/symfony.ini file and COPY it into the container instead of echoing with RUN command?

[javiereguiluz]

Should we close this issue as "won't fix for now" ... or do you think we are close to some agreement? Thanks.

[frastel]

Also I am a big fan of Docker (I hosted a Docker Workshop on the latest Symfony Live in Berlin where I created different Docker environments for the Symfony Demo App), I am of the mind that it's the wrong approach for providing a Docker setup within this project.
When we start to add the Docker solution than we also need the Vagrant, Puppet, Ansible way or whatsoever. The project would get bound and messed up with provisioning solutions. In my opinion the project should be focused on Symfony and nothing more.
Besides: The proposed Docker solution is too limited. It only creates an environment for PHP 5.6. Other possible and compatible environments are ignored.

In addition: It would be better to provide those information in additional projects, like "symfony-demo-docker", "symfony-demo-vagrant" or a generic one "symfony-demo-provisioning".

[theofidry]

@frastel 👍

Providing a VM, Docker, Vagrant or whatever will just add complexity to the project, is not really Symfony focused (although it makes sense of course, but it's out of the scope of this project IMO) and make it harder for newbies.

[javiereguiluz]

Just asking: would it make sense to write some cookbook about "Symfony + Docker" and use the "Symfony Demo" as an example?

[bocharsky-bw]

I'm 👍 for this cookbook! It'll be very interesting and keep a lot of time of other devs, IMO.

[theofidry]

Just asking: would it make sense to write some cookbook about "Symfony + Docker" and use the "Symfony Demo" as an example?

IMO it would be better to take a brand new Symfony standard rather. It would be easier to maintain.

[bocharsky-bw]

@frastel It's something that I meant here, but you describe this much better 👍

[dosten]

@frastel 👍 I'm in favor of a cookbook for "Symfony + Docker" so closing..

[ivoba]

where does this discussion continue now exactly? can you post a link to the "cookbook", pls.

[bocharsky-bw]

@ivoba I think this in the docs repo now symfony/symfony-docs#4055