Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename messenger/message-recorder.rst #14148

Closed
fabpot opened this issue Aug 30, 2020 · 1 comment
Closed

Rename messenger/message-recorder.rst #14148

fabpot opened this issue Aug 30, 2020 · 1 comment
Labels
DX hasPR A Pull Request has already been submitted for this issue. Messenger
Milestone
4.4

Comments

@fabpot
Copy link
Member

fabpot commented Aug 30, 2020

The messenger/message-recorder.rst file name is confusing as it is not related to what it explains. That's probably due to the fact that this feature started as a recorder (symfony/symfony#27844), but it was later merged with a different name (symfony/symfony#28849).

I think we should rename this file according to the new naming.

/cc @Nyholm
@xabbuh xabbuh added this to the 4.4 milestone Aug 30, 2020
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Aug 30, 2020
@xabbuh xabbuh mentioned this issue Aug 30, 2020
Merged
@Nyholm
Copy link
Member

Nyholm commented Aug 30, 2020

You are correct. It should be changed.

I was just about to start making a PR but @xabbuh was quicker =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DX hasPR A Pull Request has already been submitted for this issue. Messenger
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
3 participants
@fabpot @Nyholm @xabbuh