[Routing] added hostname pattern #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -692,6 +692,120 @@ form via the same URL, while using distinct controllers for the two actions. | |||
| Like the other requirements, the ``_method`` requirement is parsed as a regular | |||
| expression. To match ``GET`` *or* ``POST`` requests, you can use ``GET|POST``. | |||
|
|
|||
| Adding a Hostname Pattern | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
There was a problem hiding this comment.
@arnaud-lb You must specified that this feature is new in Symfony2.2
|
👍 |
| .. versionadded:: 2.2 | ||
| Hostname matching support was added in Symfony 2.2 | ||
|
|
||
| You can also match on the HTTP *hostname* of the incomming request: |
There was a problem hiding this comment.
Typo: incomming should be incoming
|
Is there something I need to setup in the .htaccess for this to work? My browser is lost and cannot find the url. |
| hostname_pattern: m.{domain} | ||
| defaults: { _controller: AcmeDemoBundle:Main:mobileHomepage } | ||
| requirements: | ||
| domain: %domain% |
There was a problem hiding this comment.
%domain% is not defined anywhere, nor explained that it would be replaced by a container param
weaverryan
added a commit
that referenced
this pull request
Nov 22, 2012
[Routing] added hostname pattern
weaverryan
added a commit
that referenced
this pull request
Nov 22, 2012
…book" article with inter-links
|
Hi Arnaud! Very nice PR! I've merged it in, but also refactored the majority of the new documentation into a new entry inside the routing component (with links to this article). Please let me know if you see any errors or want to make any changes! Thanks! |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for symfony/symfony#3378