Conversation
Given the symfony-standard repo is meant to be a bootstrap for your own projects, you are expected to change the favicon instead of keeping the Symfony one. So IMO, including the HiDPI version in the SE does not make much sense |
@stof it doesn't, but now that the PR is here... ;) |
there shouldn't be a favicon.ico (neither apple-touch-icon) in the first place. either remove them, or keep them. |
+1 for @docteurklein's comments. I don't feel too strongly in either direction. Icon looks great though :) |
Web application should contain favicons. The only problem I see with the current one is that if developers forget to change it (and they will), then in production it will be easy to know that's it's based on Symfony2. |
👍 I don't really have a strong opinion regarding the inclusion of a favicon. I only created this ticket after someone requested it on Twitter. I do think it's nice to have the HiDPI version if you are going to include a favicon, though. |
If we assume the developers are unable to change the favicon and we see this as issue then the favicon might need to be removed. But on the other hand if we do not provide an favicon and the developer forgets to add one then he gets a second request (for the failed url) against the application which is more worse than exposing that the application is using symfony. What do you think? |
The best solution would be to provide a blank favicon (I don't know if it should be HiDPI though :) ) |
@gnugat I thought about this as well but it might be then possible as well to determine if you used symfony based on the file information. If we fear just that. |
Thank you @whatthejeff. |
This PR was merged into the 2.3 branch. Discussion ---------- Add a HiDPI favicon. Difference on my retina display: ![buvjv7biuaa5wwo](https://cloud.githubusercontent.com/assets/306525/3951439/8058ac42-26d6-11e4-89f4-3d69904f7b4c.png) Commits ------- c81a658 Add a HiDPI favicon.
Difference on my retina display: