This repository has been archived by the owner on Nov 27, 2020. It is now read-only.
Autoload the AppKernel using Composer #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to register single files to load every time in Composer. Using Composer to load the AppKernel means we don't have to manually include it in all the entry points of the application.
|
👍 |
| @@ -15,7 +15,6 @@ set_time_limit(0); | |||
| * @var Composer\Autoload\ClassLoader $loader | |||
| */ | |||
| $loader = require __DIR__.'/../app/autoload.php'; | |||
There was a problem hiding this comment.
This looks like it can be simplified too.
There was a problem hiding this comment.
This is not part of this pull request, additionally I believe the variable is kept so that you can uncomment the code below: https://github.com/symfony/symfony-standard/blob/2.8/web/app.php#L11-L19
|
ping @symfony/deciders |
|
@mnapoli I think you missed https://github.com/symfony/symfony-standard/blob/2.8/web/app_dev.php#L27 |
| @@ -24,8 +24,6 @@ | |||
| $loader = require __DIR__.'/../app/autoload.php'; | |||
| Debug::enable(); | |||
|
|
|||
| require_once __DIR__.'/../app/AppKernel.php'; | |||
|
👍 |
1 similar comment
|
👍 |
|
Thank you @mnapoli. |
Tobion
added a commit
that referenced
this pull request
Oct 22, 2015
This PR was merged into the 2.8 branch. Discussion ---------- Autoload the AppKernel using Composer Fixes #868 Using Composer to load the AppKernel means we don't have to manually include it in all the entry points of the application. Commits ------- ab358a4 #868 Load the AppKernel class using Composer's autoloader
|
Shouldn't we backport this to older branches too (I don't see a reason why new Symfony 2.3 or 2.7 applications should not benefit from this change). |
|
It's not a bugfix, so IMO it shouldn't be backported. |
3 tasks
liverbool
added a commit
to Joypricecorp/Sylius
that referenced
this pull request
Dec 27, 2016
liverbool
added a commit
to Joypricecorp/Sylius
that referenced
this pull request
Dec 30, 2016
fix blog post cat name fix main page fix admin fix web add multiple root taxon add deploy param sylius override composer update fix migrate script fix vat price fix some service fix template fix product display update composer fix composer fix composer fix sf3 deploy structure fix class autoload symfony/symfony-standard#869 update node-sass fix locale fix bug - email template - auto enable user - missing shop_homepage route - taxon repo bugfix taxation fix wip
liverbool
added a commit
to Joypricecorp/Sylius
that referenced
this pull request
Dec 31, 2016
fix blog post cat name fix main page fix admin fix web add multiple root taxon add deploy param sylius override composer update fix migrate script fix vat price fix some service fix template fix product display update composer fix composer fix composer fix sf3 deploy structure fix class autoload symfony/symfony-standard#869 update node-sass fix locale fix bug - email template - auto enable user - missing shop_homepage route - taxon repo bugfix taxation fix wip bugfix fix all error small fix translation fix fix css fix css fix gulp run fix cms build gulp gulp improve fix blog post add featuredCover to post missing migrate script add title page add all posts page
liverbool
added a commit
to Joypricecorp/Sylius
that referenced
this pull request
Dec 31, 2016
fix blog post cat name fix main page fix admin fix web add multiple root taxon add deploy param sylius override composer update fix migrate script fix vat price fix some service fix template fix product display update composer fix composer fix composer fix sf3 deploy structure fix class autoload symfony/symfony-standard#869 update node-sass fix locale fix bug - email template - auto enable user - missing shop_homepage route - taxon repo bugfix taxation fix wip bugfix fix all error small fix translation fix fix css fix css fix gulp run fix cms build gulp gulp improve fix blog post add featuredCover to post missing migrate script add title page add all posts page add taxon name to post grid fix typo add link to heading content thumb better home content page post bc add product external order link add product manual tab fix image manual fix typo fix translate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #868
Using Composer to load the AppKernel means we don't have to manually include it in all the entry points of the application.