Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[HttpFoundation] implement session locking for PDO
- Loading branch information
Showing
3 changed files
with
327 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
50ec828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be considered backwards incompatible?
Does this not usually wrap your entire application in a database transaction?
50ec828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why you should not use the same database connection you use for other stuff.
50ec828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what struck me when reading this commit, but a lot of existing applications will not enforce this. I know Laravel 4 at the moment will have problems with this. Probably not something that Symfony's team should care strongly about, but wanted to hear an opinion on it at least. Thanks.
50ec828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see also #10931 which allows to lazy-connect which means it uses a seperate connection which is prob the better way to use it.
50ec828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting, thanks for your replies. Will keep an eye out for this.