[Translation] Make IcuDatFileLoader/IcuResFileLoader::load invalid resource compatible with HHVM.

[idn2104]

[Translation] HHVM throws when an invalid ResourceBundle is constructed, while zend returns FALSE from the constructor. This patch makes IcuResFileLoader and IcuDatFileLoader compatible with HHVM.

The following tests now pass on HHVM:
https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Translation/Tests/Loader/IcuDatFileLoaderTest.php#L33
https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/Translation/Tests/Loader/IcuResFileLoaderTest.php#L54

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

[fabpot]

should be false, right?

[fabpot]

There are other occurrences of this pattern in src/Symfony/Component/Intl/ResourceBundle/Reader/BinaryBundleReader.php and src/Symfony/Component/Intl/ResourceBundle/Transformer/Rule/LocaleBundleTransformationRule.php

[fabpot]

Also, it looks like that it returns null, not false in PHP.

[idn2104]

Thanks, I meant to write false where I wrote null earlier.

From the documentation it seems it should return false: http://www.php.net/manual/en/resourcebundle.create.php
Returns ResourceBundle object or FALSE on error.

If it does return false, then
src/Symfony/Component/Intl/ResourceBundle/Reader/BinaryBundleReader.php and src/Symfony/Component/Intl/ResourceBundle/Transformer/Rule/LocaleBundleTransformationRule.php
might not handle invalid bundles correctly, since false === null does not hold, and both of these error-check using if (null === $bundle) {. I can't say for sure since I haven't tested it.

[fabpot]

I've tested it and it does return null, not false (at least on PHP 5.3 and PHP 5.5 -- so it looks like the documentation is wrong).

[idn2104]

Confirmed, I've made the changes and updated the other two classes.

Is there a reason to use if (null === $bundle) instead of if (!$bundle)?

[wouterj]

Is there a reason to use if (null === $bundle) instead of if (!$bundle)?

We always do a strict comparisation of null.

[fabpot]

Thanks @idn2104.