[Filesystem] Add FTP stream wrapper context option to enable overwrite #11772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,10 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 2.5.? | |||
There was a problem hiding this comment.
new features will never be added in 2.5.x
There was a problem hiding this comment.
Is there any convention/manual for this file?
I've read the contribution guide and didn't find anything regarding which version should I put there.
Or should I simply skip the line with version number?
There was a problem hiding this comment.
when you submit to master, it is for the next minor version (i.e. 2.6.0).
for bug fixes in patch versions, we don't edit this file
paq85
force-pushed
the
filesystem_ftp_override
branch
from
108f41d
to
e0dab4a
Compare
paq85
force-pushed
the
filesystem_ftp_override
branch
from
e0dab4a
to
a4da34f
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @xstream-ingest-dev. |
fabpot
added a commit
that referenced
this pull request
Aug 31, 2014
…le overwrite (Damian Sromek) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11772). Discussion ---------- [Filesystem] Add FTP stream wrapper context option to enable overwrite | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Without this change it's not possible to override a file on FTP by calling Filesystem::copy($originFile, $targetFile, true) as PHP/FTP server responds with error like: fopen(ftp://...@ftp/file.txt): failed to open stream: Remote file already exists and overwrite context option not specified FTP server reports 213 166440 [] TODO: Write an integration tests? How? Use some real FTP server? Commits ------- c056a9c [Filesystem] Add FTP stream wrapper context option to enable overwrite (override)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change it's not possible to override a file on FTP by calling Filesystem::copy($originFile, $targetFile, true) as PHP/FTP server responds with error like:
fopen(ftp://...@ftp/file.txt): failed to open stream: Remote file already exists and overwrite context option not specified FTP server reports 213 166440 []
TODO: Write an integration tests? How? Use some real FTP server?