[Intl] Improved bundle reader implementations #11907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmozart
force-pushed
the
fix-bundlereaders
branch
from
1ce58ac
to
c43fc14
Compare
| return; | ||
| // Use array_key_exists() for arrays, isset() otherwise | ||
| if (is_array($array) && !array_key_exists($index, $array) || !is_array($array) && !isset($array[$index])) { | ||
| throw new OutOfBoundsException('The index '.$index.' does not exist.'); |
|
👍 |
|
Of course, tests should be fixed first and CS issues fixed. |
| $array = $array->offsetGet($index); | ||
| } else { | ||
| $array = $array[$index]; | ||
| } | ||
| } |
There was a problem hiding this comment.
You can use ternary operator $array = ($array instanceof \ArrayAccess) ? $array->offsetGet($index) : $array[$index];
There was a problem hiding this comment.
I wonder why I did this here.. need to check
webmozart
force-pushed
the
fix-bundlereaders
branch
2 times, most recently
from
5e61a1a
to
8a3a164
Compare
|
Updated. |
| * | ||
| * @author Bernhard Schussek <bschussek@gmail.com> | ||
| * | ||
| * @internal |
There was a problem hiding this comment.
is it really internal while being at the root of the component ? this looks weird to me. Internal classes used for the building of ICU data only should probably be placed in a subnamespace, keeping the top-level of the component for the poublic API
There was a problem hiding this comment.
I'm going to remove this flag in 2.6, but I don't want anybody to rely on this code until I'm sure this class will stay as it is.
|
ping @symfony/deciders |
webmozart
force-pushed
the
fix-bundlereaders
branch
from
8a3a164
to
33ec940
Compare
webmozart
force-pushed
the
fix-bundlereaders
branch
from
33ec940
to
c3cce5c
Compare
webmozart
added a commit
that referenced
this pull request
Sep 15, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] Improved bundle reader implementations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR extracts bundle reader improvements from #9206. The code is internal and used for resource bundle generation only, so I did not care about BC too much. Commits ------- c3cce5c [Intl] Improved bundle reader implementations
webmozart
added a commit
that referenced
this pull request
Sep 30, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] Integrated ICU data into Intl component #1 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11447, #10807 | License | MIT | Doc PR | - This PR is an alternative implementation to #11884. It depends on ~~#11906~~ and ~~#11907~~ being merged first (~~these are included in the diff until after a merge+rebase~~ merged+rebased now). With this PR, the ICU component becomes obsolete. The ICU data is bundled with Intl in two different formats: JSON and the binary ICU resource bundle format (version 2) readable by PHP's `\ResourceBundle` class. For a performance comparison between the two, see my [benchmark](/webmozart/json-res-benchmark). ~~The data is contained in two zip files: json.zip (2.6MB) and rb-v2.zip (3.8MB). The handler~~ ```php \Symfony\Component\Intl\Composer\ScriptHandler::decompressData() ``` ~~needs to be added as Composer hook and decompresses the data after install/update.~~ The data is included as text/binary now. Git takes care of the compression. Before this PR can be merged, I would like to find out what the performance difference between the two formats is in real applications. For that, I need benchmarks from some real-life applications which use ICU data - e.g. in forms (language drop-downs, country selectors etc.) - for both the JSON and the binary data. You can force either format to be used by hard-coding the return value of `Intl::detectDataFormat()` to `Intl::JSON` and `Intl::RB_V2` respectively. I'll also try to create some more realistic benchmarks. If JSON is not significantly slower/takes up significantly more memory than the binary format, we can drop the binary format altogether. Commits ------- be819c1 [Intl] Integrated ICU data into Intl component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts bundle reader improvements from #9206.
The code is internal and used for resource bundle generation only, so I did not care about BC too much.