[FrameworkBundle] cache:clear command fills *.php.meta files with wrong data #12137
Conversation
This unit test shows, that right after executing 'cache:clear' command (which warms up cache also), *.php.meta files contains wrong information
| use Symfony\Component\HttpKernel\Bundle\BundleInterface; | ||
| use Symfony\Component\HttpKernel\Kernel; | ||
|
|
||
| class AppKernel extends Kernel |
There was a problem hiding this comment.
TestAppKernel would sound better. Some IDE's (such as eclipse) will index this file and provide auto complete on it or quick searches. That means that besides of the AppKernel in your own applications, you will always see a second pop up. This can be confusing.
There was a problem hiding this comment.
I am agree with you. But There is also exists at least Symfony\Bundle\FrameworkBundle\Tests\Functional\app\AppKernel class. So, I'll fix it, but later (probably with CacheClearCommand fix)
|
I don't know ahy tests are failed. Fail does not related to this PR. |
|
Could someone review? |
| @@ -0,0 +1,2 @@ | |||
| framework: | |||
| secret: test | |||
There was a problem hiding this comment.
you should add a newline at the end of the file
1. Fix code review marks 2. Added test for kernel file existence in meta file.
|
|
||
| use Symfony\Bundle\FrameworkBundle\FrameworkBundle; | ||
| use Symfony\Component\Config\Loader\LoaderInterface; | ||
| use Symfony\Component\HttpKernel\Bundle\BundleInterface; |
There was a problem hiding this comment.
The BundleInterface is never used.
|
Test failures does not related to code. Could someone merge/reject this? |
|
👍 |
|
Thank you @Strate. |
…es with wrong data (Strate) This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #12137). Discussion ---------- [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12110 | License | MIT Test and fix of ticket #12110 Commits ------- 76273bf [FrameworkBundle] cache:clear command fills *.php.meta files with wrong data
Test and fix of ticket #12110