Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] unserialize() conflicts with extended constructor #12232

Closed
kingcrunch opened this issue Oct 15, 2014 · 6 comments
Closed

[HttpKernel] unserialize() conflicts with extended constructor #12232

kingcrunch opened this issue Oct 15, 2014 · 6 comments

Comments

@kingcrunch
Copy link
Contributor

Kernel::unserialize() prevents one from extending the constructor. Even when I overwrite serialize() and unserialize() something tries unserialize my custom AppKernel-class with some inappropiate during cache creation.

@Koc
Copy link
Contributor

Koc commented Oct 15, 2014

relates to #8500

@linaori
Copy link
Contributor

linaori commented Oct 16, 2014

I'm running against this issue too (see hostnet/hnDependencyInjectionPlugin#1). We've had to (more or less) implement the constructor with a custom argument but loading it from the cache is a bit buggy in some cases: Hostnet\HnDependencyInjectionPlugin\Symfony1Kernel::__construct(). I don't think this is an easy fix though.

@kingcrunch kingcrunch changed the title [HttpKernel] [HttpKernel] unserialize() conflicts with extended constructor Oct 16, 2014
@linaori
Copy link
Contributor

linaori commented Jan 27, 2016

@kingcrunch this issue isn't present for me anymore and I don't think this will be fixed. Is the issue still something you consider should be fixed?

@kingcrunch
Copy link
Contributor Author

I am a little bit confused of this phrase

this issue isn't present for me anymore and I don't think this will be fixed.

If it isn't present anymore, it is fixed, right?

However, back in the days I used a different approach, thus for me it is not relevant anymore, what doesn't mean, it doesn't exists, or that it can affect other people.

@linaori
Copy link
Contributor

linaori commented Jan 29, 2016

This issue was for our custom kernel implementation for symfony1 migration, but most of our apps have been migrated to a point where we no longer need it.

@javiereguiluz
Copy link
Member

Let's close this issue because @kingcrunch and @iltar no longer consider it relevant. We'll reopen it if we get more reports about this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants