[Security][listener] change priority of switchuser #12313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, this makes sense. Switching to a different user should indeed be done before validating the access with the current user. @aitboudad can you fix the tests ? The fact that the order of listeners is not the same anymore is making them fail |
|
@stof done |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Oct 24, 2014
…dad) This PR was merged into the 2.3 branch. Discussion ---------- [Security][listener] change priority of switchuser | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Hi, I have the following users: - Manager: Allowed to access to (/admin) and has a role ROLE_ALLOWED_TO_SWITCH - Partner: Allowed to access to (/partner) When I attempt to switch to partner user I get "Access denied", well I think the switchuser listener must be registred before access listener. Commits ------- 5f8047d [Security][listener] change priority of switchuser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have the following users:
When I attempt to switch to partner user I get "Access denied", well I think the switchuser listener must be registred before access listener.