[Routing] serialize the compiled route to speed things up #12329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'tokens' => $this->tokens, | ||
| 'staticPrefix' => $this->staticPrefix, | ||
| 'regex' => $this->regex, | ||
| 'pathVariables' => $this->pathVariables, |
There was a problem hiding this comment.
Can you use underscore names as this is what we are using everywhere else for array keys?
| * Tests that the compiled version is also serialized to prevent the overhead | ||
| * of compiling it again after unserialize. | ||
| */ | ||
| public function testSerializeWhenCompiled() |
There was a problem hiding this comment.
I am a bit confused about that test. As far as I read this test, I am pretty sure it should have passed without the actual patch as well.
There was a problem hiding this comment.
Yes it's not to test the compiled but it ensures that we don't break the deserialization in the future.
There was a problem hiding this comment.
Oh wait, I thought you commented on testSerializedRepresentationKeepsWorking.
No the test does not pass without the patch because then the compiled attributes are not equal and thus the routes are not equal.
This also makes the CompiledRoute implement Serializable in order to: 1. make the serialization format shorter 2. have no null bytes in there, which the native serializer add for private properties, and thus would complicate saving in databases etc. 3. We should add to our symfony BC promise, that only classes that implement Serializable are ensured to be deserializable correctly with serialized representations of the class in previous symfony versions.
Tobion
force-pushed
the
route-serialize-compiled
branch
from
1506011
to
fd88de7
Compare
| @@ -105,12 +108,16 @@ public function serialize() | |||
| 'options' => $this->options, | |||
| 'schemes' => $this->schemes, | |||
| 'methods' => $this->methods, | |||
| 'compiled' => $this->compiled, | |||
There was a problem hiding this comment.
@fabpot this will conflict with newer branches that have a condition, so you are aware when merging.
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 28, 2014
…(Tobion) This PR was merged into the 2.3 branch. Discussion ---------- [Routing] serialize the compiled route to speed things up | Q | A | ------------- | --- | Bug fix? | no | New feature? | not really | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12012, #12220 | License | MIT | Doc PR | - This also makes the CompiledRoute implement Serializable in order to: 1. make the serialization format shorter 2. have no null bytes in there, which the native serializer add for private properties, and thus would complicate saving in databases etc. 3. Since the Route now includes the CompiledRoute in the serialization, the CompiledRoute serialization must be consistent as well. We can only ensure that in future symfony version by implementing Serializable. We should add to our symfony BC promise, that only classes that implement Serializable are ensured to be deserializable correctly with serialized representations of the class in previous symfony versions. Commits ------- fd88de7 [Routing] serialize the compiled route to speed things up
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the CompiledRoute implement Serializable in order to:
We should add to our symfony BC promise, that only classes that implement Serializable are ensured to be deserializable correctly with serialized representations of the class in previous symfony versions.