[DomCrawler] Added support for 'link' tags in the Link class #12487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Below is the failed test output. |
|
Thank you @stephaneseng. |
fabpot
added a commit
that referenced
this pull request
Nov 16, 2014
…ss (StephaneSeng) This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12487). Discussion ---------- [DomCrawler] Added support for 'link' tags in the Link class | Q | A | ------------- | --- | Bug fix? | No | New feature? | Not really | BC breaks? | No | Deprecations? | No | Tests pass? | Yes (at least those of DomCrawler) | Fixed tickets | N/A | License | MIT | Doc PR | N/A My use case is that I crawl web pages for RSS links so I need to retrieve the 'href' attributes of 'link' elements. I would like to use the Link class to resolve encountered 'href' relative URLs. Please note that I did not replace `if ('a' !== $node->nodeName && 'area' !== $node->nodeName)` with `if (!$node->hasAttribute('href'))` to ensure backward compatibility. Indeed, according to http://www.w3.org/TR/html5/links.html, the 'href' attribute is optional for 'a' and 'area' elements. Commits ------- d8d6fcf [DomCrawler] Added support for link tags in the Link class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is that I crawl web pages for RSS links so I need to retrieve the 'href' attributes of 'link' elements.
I would like to use the Link class to resolve encountered 'href' relative URLs.
Please note that I did not replace
if ('a' !== $node->nodeName && 'area' !== $node->nodeName)withif (!$node->hasAttribute('href'))to ensure backward compatibility.Indeed, according to http://www.w3.org/TR/html5/links.html, the 'href' attribute is optional for 'a' and 'area' elements.