[Bundle][FrameworkBundle] be smarter when guessing the document root #12525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 20, 2014
xabbuh
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #12524 |
| License | MIT |
| Doc PR |
|
This change makes it easy to start the built-in web server even when the user is not the in project directory. However, this may affect people how changed the kernel's root directory, but who kept |
|
Thank you @xabbuh! It worked like a charm for me. Regarding the potential issue that you mentioned, in my opinion is not that important because people changing the kernel's root directory are advanced enough to:
|
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 20, 2014
…ument root (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Bundle][FrameworkBundle] be smarter when guessing the document root | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12524 | License | MIT | Doc PR | Commits ------- e28f5b8 be smarter when guessing the document root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.