[Filesystem] symlink use RealPath instead LinkTarget #12761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Nov 29, 2014
aitboudad
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
|
Can you add some unit tests? |
|
Ok, I'll try ;) |
|
done |
|
@aitboudad Does this fix #12793? That issue is about a minor BC break because when a symlink fails, it now throws an exception. If this fixes that issue, I'm not clear now (but it's likely I'm missing something!) Thanks! |
|
@weaverryan sorry I didn't read the full description for #12793 :p , this PR fix symlink to a relative pathname. |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Dec 12, 2014
…oudad) This PR was squashed before being merged into the 2.3 branch (closes #12761). Discussion ---------- [Filesystem] symlink use RealPath instead LinkTarget | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- a8b8d33 [Filesystem] symlink use RealPath instead LinkTarget
|
@weaverryan No, #12793 is not fixed by this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.