fix session restart on PHP 5.3 #12961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also removes some useless code
| @@ -89,7 +89,7 @@ public function setSessionData(array $array) | |||
| */ | |||
| public function start() | |||
| { | |||
| if ($this->started && !$this->closed) { | |||
There was a problem hiding this comment.
this was useless because closed is always false if started is true
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Dec 12, 2014
This PR was merged into the 2.3 branch. Discussion ---------- fix session restart on PHP 5.3 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #12562 | License | MIT | Doc PR | - this also removes some useless code Commits ------- b9d3c92 fix session restart on PHP 5.3
| @@ -209,18 +211,20 @@ public function testSetSaveHandler54() | |||
| /** | |||
| * @expectedException \RuntimeException | |||
| */ | |||
| public function testStartedOutside53() | |||
| public function testStartedOutside() | |||
There was a problem hiding this comment.
This method should be named testStarted. I'll send a pull...
There was a problem hiding this comment.
Opps, oh yeh. Sorry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also removes some useless code