[HttpKernel] Check if "symfony/proxy-manager-bridge" package is installed #14266
Conversation
hason
commented
Apr 8, 2015
hason
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -662,7 +662,7 @@ protected function getContainerBuilder() | |||
| { | |||
| $container = new ContainerBuilder(new ParameterBag($this->getKernelParameters())); | |||
|
|
|||
| if (class_exists('ProxyManager\Configuration')) { | |||
| if (class_exists('ProxyManager\Configuration') && class_exists('Symfony\Bridge\ProxyManager\LazyProxy\Instantiator\RuntimeInstantiator')) { | |||
There was a problem hiding this comment.
you can remove the first condition
There was a problem hiding this comment.
I think not. This PR solves a case when "symfony/framework-bundle" and "ocramius/proxy-manager" are installed. The first condition solves a case when "symfony/symfony" is installed and "ocramius/proxy-manager" not.
There was a problem hiding this comment.
but I'm not sure If that makes any sense, if class RuntimeInstantiator exist then ProxyManager\Configuration exist also https://github.com/hason/symfony/blob/pm/src/Symfony/Bridge/ProxyManager/composer.json#L21 without checking it
There was a problem hiding this comment.
@aitboudad you are only looking at the case of installing subtree packages. When installing the fullstack repo, the RuntimeInstantiator class always exists, as it is part of the fullstack repo. But this does not mean that the ProxyManager library is installed
|
ping @aitboudad @fabpot |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @hason. |
…ge is installed (hason) This PR was merged into the 2.3 branch. Discussion ---------- [HttpKernel] Check if "symfony/proxy-manager-bridge" package is installed | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 43cc877 [HttpKernel] Check if "symfony/proxy-manager-bridge" package is installed
