[2.6] Towards 100% HHVM compat #15159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hhvm-fixes
branch
from
7294c2f
to
298e72d
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
hhvm-fixes
branch
7 times, most recently
from
d851b46
to
d5afac0
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
hhvm-fixes
branch
4 times, most recently
from
394af96
to
01e2762
Compare
|
|
nicolas-grekas
force-pushed
the
hhvm-fixes
branch
from
01e2762
to
4bbd73c
Compare
| } else { | ||
| // PHP 5.4 and up wrap exceptions thrown by JsonSerializable | ||
| // objects in a new exception that needs to be removed. | ||
| // Hopefully, PHP 5.5 and up do not trigger any warning anymore. |
There was a problem hiding this comment.
are you sure that hopefully is the right word here ? It looks weird
There was a problem hiding this comment.
yes, these warning where wrong and duplicated the feature provided by json_last_error_msg()
There was a problem hiding this comment.
but Hopefully looks weird. We don't hope that PHP 5.5 fixed it. We know it fixed it. Fortunately looks better IMO
nicolas-grekas
force-pushed
the
hhvm-fixes
branch
from
4bbd73c
to
5b5b890
Compare
nicolas-grekas
force-pushed
the
hhvm-fixes
branch
from
5b5b890
to
8a78255
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 1, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [2.6] Towards 100% HHVM compat | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #9917, #11418 | License | MIT | Doc PR | - Failing components: - [x] HttpFoundation - [x] HttpKernel - [x] VarDumper Related HHVM issues: - facebook/hhvm#5563 Commits ------- 8a78255 [2.6] Towards 100% HHVM compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing components:
Related HHVM issues: