[Yaml] throw a ParseException on invalid data type #15361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this check, PHP would trigger a warning when an array was passed to `trim()`. The parser must throw a `ParseException` instance on a malformed YAML string instead.
|
Sorry, this fix must be merged into the |
|
👍 Status: Reviewed |
|
👍 thanks @xabbuh |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 26, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.6 branch instead (closes #15361). Discussion ---------- [Yaml] throw a ParseException on invalid data type | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15234 | License | MIT | Doc PR | Without this check, PHP would trigger a warning when an array was passed to `trim()`. The parser must throw a `ParseException` instance on a malformed YAML string instead. Commits ------- adc6b30 [Yaml] throw a ParseException on invalid data type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, PHP would trigger a warning when an array was passed
to
trim(). The parser must throw aParseExceptioninstance on amalformed YAML string instead.