Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report deprecations when running a cli app #15568

Closed
nicolas-grekas opened this issue Aug 17, 2015 · 8 comments
Closed

Report deprecations when running a cli app #15568

nicolas-grekas opened this issue Aug 17, 2015 · 8 comments

Comments

@nicolas-grekas
Copy link
Member

The deprecations could be summarized/aggregated in a similar way to our phpunit bridge, maybe with a new global cli option.

@stof
Copy link
Member

stof commented Aug 17, 2015

@nicolas-grekas the trace should also be added in log messages for the profiler (the profiler panel is able to display the trace if it is passed in the logging context as trace, but the Debug component does not pass it anymore)

@linaori
Copy link
Contributor

linaori commented Aug 18, 2015

I had a colleague checking 2.8 deprecations and he reported it to be nearly impossible to trace them unless you dig a lot in the code. 👍 for a stacktrace.

@nicolas-grekas nicolas-grekas changed the title Report deprecations with stack trace when running a cli app Report deprecations when running a cli app Aug 29, 2015
@javiereguiluz
Copy link
Member

@stof's comment is very important. Right now the profiler looks like this for the deprecation messages:

deprecation-logs

We display neither the trace nor the file name + line number, so this information is not very useful at the moment.

@nicolas-grekas
Copy link
Member Author

@javiereguiluz are you sure you have the last version? Because we fixed this a few days ago...

@javiereguiluz
Copy link
Member

I thought I had the latest version. Can you please point me to the relevant PR that changed this? Thanks.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Sep 7, 2015 via email

@javiereguiluz
Copy link
Member

Thanks for the link! It now works like a charm:

deprecation-stack-trace

deprecation-stack-trace-expanded

@nicolas-grekas
Copy link
Member Author

This thread has been hijacked for adding a stacktrace, which is available now, closing. If someone else wants to create an other issue on the original topic, or better a PR, please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants