[2.7][Asset] Ability to set empty version strategy in packages #16511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewgRa
changed the title
This was referenced Nov 10, 2015
|
Won't the version be |
|
There is a case, if version is omitted - then default strategy used. If we change it and if in xml omitted version considered as empty strategy (also as we need sync same logic for php, yml then) - we will have broken BC. There is also legacy code (framework templating configuration) that have different logic - omitted considered as empty. |
|
There is no possible to set attribute in xml to null as far as I know :( |
|
Ping @fabpot Any feedback on this? This bug was introduced with Symfony 2.7 and has not been resolved yet. |
|
👍 @ewgRa Can you rebase to get rid of the 2 merge commit that prevents me from merging? Or even better, squash all commits. Thanks. |
|
@fabpot done |
|
Thank you @ewgRa. |
fabpot
added a commit
that referenced
this pull request
Jan 24, 2016
…ages (ewgRa) This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Asset] Ability to set empty version strategy in packages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no, but not sure, as for me test was wrong | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14832 | License | MIT | Doc PR | Comment about '' thing. As you can see in xml test - we can't for attribute set null value. And for xml version '' empty string considered as null value, that affect all others formats and test is changed. Commits ------- 646fc9c Ability to set empty version strategy in packages
| @@ -547,7 +553,12 @@ private function addAssetsSection(ArrayNodeDefinition $rootNode) | |||
| ->prototype('array') | |||
| ->fixXmlConfig('base_url') | |||
| ->children() | |||
| ->scalarNode('version')->defaultNull()->end() | |||
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [2.7][Asset] Add defaultNull to version configuration | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14832, #16511 | License | MIT | Doc PR | In #16511 PR was omitted defaultNull version for one case. Commits ------- 65adb72 add defaultNull to version
fabpot
added a commit
that referenced
this pull request
Jan 26, 2016
This PR was squashed before being merged into the 3.1-dev branch (closes #17532). Discussion ---------- [Asset] Version as service | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While I working on #14832 I realize that all this problems and hidden magic can be avoided, if we will have ability to set asset version strategy as service. This PR implementation of this idea. Now it is possible to do something like this: ```yaml framework: assets: version_strategy: assets.custom_version_strategy base_urls: http://cdn.example.com packages: foo: base_urls: ["https://example.com"] version_strategy: assets.custom_version_strategy ``` There is can be some conflicts with #16511 when it will be in master Commits ------- 52d116b [Asset] Version as service
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment about '' thing. As you can see in xml test - we can't for attribute set null value. And for xml version '' empty string considered as null value, that affect all others formats and test is changed.