[DI][autowiring] throw exception when many services use the same class. #16642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Nov 23, 2015
aitboudad
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #16639 |
| Tests pass? | yes |
| License | MIT |
|
@dunglas can you help review this. I can't quite follow the logic, but it might be late :) |
|
👍 looks good to me but it's late so I can be wrong :-) |
| if (isset($this->types[$typeHint->name])) { | ||
| $value = new Reference($this->types[$typeHint->name]); | ||
| } elseif (isset($this->serviceTypes[$typeHint->name]) && isset($this->notGuessableTypes[$typeHint->name])) { |
There was a problem hiding this comment.
why is this isset($this->notGuessableTypes[$typeHint->name])) and not the opposite !isset($this->notGuessableTypes[$typeHint->name]))?
There was a problem hiding this comment.
I slightly simplified the code now, if the type is in notGuessableTypes we should throw an exception.
aitboudad
force-pushed
the
issue_16639
branch
from
1b73bc6
to
fb3bc6e
Compare
aitboudad
force-pushed
the
issue_16639
branch
from
fb3bc6e
to
a21a016
Compare
|
@dunglas can you look at this in more detail? It's a really simple patch right now (@aitboudad reworked it), but it won't get merged until/unless we can give it a for-sure ok. |
|
👍 nice work @aitboudad! |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2015
…e same class. (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [DI][autowiring] throw exception when many services use the same class. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #16639 | Tests pass? | yes | License | MIT Commits ------- a21a016 [DI][autowiring] throw exception when many services use the same class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.