[Form] Fixed wrong usages of the "text" type #16677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Nov 26, 2015
webmozart
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
This can't be done in |
|
Ah yes, this was originally based on master. Will fix. |
|
Fixed now. |
| @@ -11,12 +11,12 @@ | |||
|
|
|||
| namespace Symfony\Component\Form; | |||
|
|
|||
| use Symfony\Component\Form\Exception\RuntimeException; | |||
There was a problem hiding this comment.
please don't do use-reordering changes in 2.8 as it can cause conflicts when merging later
There was a problem hiding this comment.
Ah, this was done automatically by PhpStorm. Will revert this.
I think we should always keep all use statements ordered in all branches. This makes merging much easier in general. StyleCI, for example, does that automatically.
There was a problem hiding this comment.
Yeah but then we should start with it in 2.3.
|
👍 |
|
Thank you @webmozart. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fixed wrong usages of the "text" type | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 9149622 [Form] Fixed wrong usages of the "text" type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.