Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] add subject variable to expression context #16755

Merged
merged 1 commit into from Nov 30, 2015
Merged

[Security] add subject variable to expression context #16755

merged 1 commit into from Nov 30, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 30, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #16600
License MIT
Doc PR TODO

@xabbuh xabbuh mentioned this pull request Nov 30, 2015
Merged
@xabbuh
Copy link
Member Author

xabbuh commented Nov 30, 2015

If someone has an idea how we could trigger a deprecation warning when the user accesses the deprecated object variable, I will be happy to include such a change here too.

@fabpot
Copy link
Member

fabpot commented Nov 30, 2015

I'm going to merge this one now before 2.8 release. For the deprecation warning, we can add it later on. @xabbuh Can you create a ticket so that we don't forget about this?

@fabpot
Copy link
Member

fabpot commented Nov 30, 2015

Thank you @xabbuh.

@fabpot fabpot merged commit 346943e into symfony:2.8 Nov 30, 2015
fabpot added a commit that referenced this pull request Nov 30, 2015
@fabpot
feature #16755 [Security] add subject variable to expression context …
37ceef0 
…(xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[Security] add subject variable to expression context

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #16600
| License       | MIT
| Doc PR        | TODO

Commits
-------

346943e add subject variable to expression context
@xabbuh xabbuh deleted the introduce-subject-variable branch November 30, 2015 12:29
@stof
Copy link
Member

stof commented Nov 30, 2015

Deprecation object would make it very hard to write expressions compatible with both 2.7 and 3.0 (or 2.8 without deprecations): the expression language does not give us enough expressiveness to handle this (allowed variables are checked at compile time)

@xabbuh
Copy link
Member Author

xabbuh commented Nov 30, 2015

@stof What would you suggest instead?

@fabpot
Copy link
Member

fabpot commented Nov 30, 2015

I've merged 2.8 into master by keeping both object and subject.

This was referenced Nov 30, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xabbuh @fabpot @stof @carsonbot