Able to load big xml files with DomCrawler

[zorn-v]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

[xabbuh]

Does this option have any drawbacks when parsing non-huge documents?

[zorn-v]

Manual says that it only relaxes any hardcoded limit from the parser.
https://secure.php.net/manual/en/libxml.constants.php

It only for Libxml >= 2.7.0 but I dont know is version below is widespread.
For ex. on CentOS 6 is 2.7.6

[dosten]

Maybe we need something like:
LIBXML_NONET | (defined('LIBXML_PARSEHUGE') ? LIBXML_PARSEHUGE : 0)

[zorn-v]

This constant defined in php extension and avail since PHP >= 5.3.2 and PHP >= 5.2.12 which is less than min requirement for DomCrawler

[stof]

@zorn-v is it always defined, or does it depend on the libxml version being used ? Distributions generally compile PHP against the system libxml rather than the version bundled with PHP, meaning that it may change

[zorn-v]

You are right. In php 5.3.9 ext\libxml\libxml.c

#if LIBXML_VERSION >= 20703
    REGISTER_LONG_CONSTANT("LIBXML_PARSEHUGE",  XML_PARSE_HUGE,         CONST_CS | CONST_PERSISTENT);
#endif 

So minimum libxml version actualy 2.7.3 not 2.7.0

[zorn-v]

I can find only one dist with libxml2 < 2.7.3 - CentOS 5. But there PHP 5.1.6 (in standart repo)
Even on Debian 6 it 2.7.8

I think threre is no sense in that check, but I add it just in case.

[rvanlaak]

Libxml introduced XML_MAX_TEXT_LENGTH in 2.9.0 and results in a limit of ~10MB per node. Libxml's MAX_TEXT_LENGTH cannot be changed via PHP, it is compiled in the library.

We recently updated the library to 2.9.2 from 2.8.0 and aren't able to parse big xml files with the Serializer because of this. So, I think this should also be configurable for the Serializer component. Our problem is that the decoding happens before controller in the FOS\RestBundle\EventListener\BodyListener:114, but we only want to enable this setting for a couple of specific requests.

Please also mention http://symfony.com/blog/security-release-symfony-2-0-17-released about the LIBXML_PARSEHUGE constant, it should definitely not be there by default.

[fabpot]

Thank you @zorn-v.

[rvanlaak]

Think this also should be applied to the XmlEncoder. How can we make sure the variable is defined before the RestBundle's BodyListener without putting it in app.php?