[Form] improve deprecation message for "empty_value" and "choice_list" options. #17119
Conversation
hhamon
commented
Dec 23, 2015
hhamon
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
hhamon
force-pushed
the
choice-type-improve-deprecation-message
branch
from
f0a0aff
to
71a1736
Compare
|
|
|
So |
hhamon
force-pushed
the
choice-type-improve-deprecation-message
branch
from
71a1736
to
ff26475
Compare
|
Changed |
|
Does and btw, using the type name rather than the type class would be better in 2.7. People are referencing it by name, not by class in 2.7. |
|
That's a good point! I'm gonna try to add the type name using the |
|
This snippet works on PHP 5.3.29. <?php
namespace Foo\Bar;
class A
{
public function b($c)
{
$d = function () use ($c) {
return strtoupper($c).' ('.__CLASS__.')';
};
return sprintf('Hello %s!', $d());
}
}
$a = new A();
echo $a->b('Hugo');It correctly outputs |
| @@ -294,7 +294,7 @@ public function configureOptions(OptionsResolver $resolver) | |||
|
|
|||
| $choiceListNormalizer = function (Options $options, $choiceList) use ($choiceListFactory) { | |||
| if ($choiceList) { | |||
| @trigger_error('The "choice_list" option is deprecated since version 2.7 and will be removed in 3.0. Use "choice_loader" instead.', E_USER_DEPRECATED); | |||
| @trigger_error(sprintf('The "choice_list" option of a %s form type is deprecated since version 2.7 and will be removed in 3.0. Use "choice_loader" instead.', __CLASS__), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
I propose to be a bit shorter : The "choice_list" option of %s is deprecated...
There was a problem hiding this comment.
yep! Will do it later tonight ;)
hhamon
force-pushed
the
choice-type-improve-deprecation-message
branch
from
ff26475
to
72453a7
Compare
|
@nicolas-grekas @stof is it better now? |
hhamon
force-pushed
the
choice-type-improve-deprecation-message
branch
3 times, most recently
from
8cd34fe
to
88e13a0
Compare
| if ($choiceList) { | ||
| @trigger_error('The "choice_list" option is deprecated since version 2.7 and will be removed in 3.0. Use "choice_loader" instead.', E_USER_DEPRECATED); | ||
| @trigger_error(sprintf('The "choice_list" option of the "%s" form type (%s) is deprecated since version 2.7 and will be removed in 3.0. Use "choice_loader" instead.', $that->getName(), __CLASS__), E_USER_DEPRECATED); |
There was a problem hiding this comment.
since we know that getName is deprecated in 2.8, shouldn't we only tell about __CLASS__? At least that's what should be done in 2.8, isn't it?
There was a problem hiding this comment.
@nicolas-grekas this PR targets Symfony 2.7. In 2.8, we should indeed change it to use the class name
There was a problem hiding this comment.
When it's merged, I will open the other PR against the 2.8 branch.
hhamon
force-pushed
the
choice-type-improve-deprecation-message
branch
2 times, most recently
from
558293c
to
b58c0e5
Compare
…_list" options in the ChoiceType class.
hhamon
force-pushed
the
choice-type-improve-deprecation-message
branch
from
b58c0e5
to
7878536
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @hhamon. |
…choice_list" options. (hhamon) This PR was merged into the 2.7 branch. Discussion ---------- [Form] improve deprecation message for "empty_value" and "choice_list" options. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 7878536 [Form] improve deprecation messages for the "empty_value" and "choice_list" options in the ChoiceType class.
