[DoctrineBridge] [PropertyInfo] Catch Doctrine\ORM\Mapping\MappingException

[dunglas]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Sometimes the Doctrine ORM ClassMetadataFactory throws a Doctrine\Common\Persistence\Mapping\MappingException exception, sometime a Doctrine\ORM\Mapping\MappingException.
This PR catch both.

Port of dunglas/php-property-info#10.

[Tobion]

Doctrine is missing to document the possible exception: https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Persistence/Mapping/ClassMetadataFactory.php#L47

As it does not specify which exception can be thrown, it would make more sense the catch all exceptions (\Exception).

[nicolas-grekas]

Catching all exceptions to ignore them could start a debugging nightmare...

[stof]

The ORM MappingException case here can happen when using older versions of the ORM (in newer versions, the ORM exceptions extends from the Common one and so is catched already).

@Tobion an invalid mapping always throws a MappingException. Other exceptions could be thrown because of bugs, but these one should be kept uncaught here.

[Tobion]

@stof I don't see that ORM MappingException extends the common one: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/MappingException.php#L27

[stof]

oh, I thought it did. This looks weird.

[nicolas-grekas]

👍

[xabbuh]

👍

[fabpot]

Thank you @dunglas.