Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #14246 [Filesystem] dumpFile() non atomic #17195

Merged
merged 1 commit into from Dec 31, 2015
Merged

bug #14246 [Filesystem] dumpFile() non atomic #17195

merged 1 commit into from Dec 31, 2015

Conversation

hboomsma
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14246
License MIT
Doc PR none

Remove race condition where dumpFile has written the resulting file but has not given access yet.

@nicolas-grekas
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 31, 2015

👍

Status: Reviewed

@nicolas-grekas
Copy link
Member

Thank you @hboomsma.

@nicolas-grekas nicolas-grekas merged commit e4015d5 into symfony:2.3 Dec 31, 2015
nicolas-grekas added a commit that referenced this pull request Dec 31, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

bug #14246 [Filesystem] dumpFile() non atomic

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14246
| License       | MIT
| Doc PR        | none

Remove race condition where `dumpFile` has written the resulting file but has not given access yet.

Commits
-------

e4015d5 bug #14246 [Filesystem] dumpFile() non atomic
This was referenced Jan 14, 2016
@fabpot fabpot mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants