Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Yaml] cast arrays to objects after parsing has finished #17197

Merged
merged 1 commit into from Jan 4, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 31, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17190
License MIT
Doc PR

Casting arrays to objects must happen after the complete YAML string has
been parsed to avoid errors when parsing subsequent lines.

Casting arrays to objects must happen after the complete YAML string has
been parsed to avoid errors when parsing subsequent lines.
@stof
Copy link
Member

stof commented Dec 31, 2015

👍

@fabpot
Copy link
Member

fabpot commented Jan 4, 2016

Thank you @xabbuh.

@fabpot fabpot merged commit 8251d67 into symfony:2.8 Jan 4, 2016
fabpot added a commit that referenced this pull request Jan 4, 2016
…xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[Yaml] cast arrays to objects after parsing has finished

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17190
| License       | MIT
| Doc PR        |

Casting arrays to objects must happen after the complete YAML string has
been parsed to avoid errors when parsing subsequent lines.

Commits
-------

8251d67 cast arrays to objects after parsing has finished
@xabbuh xabbuh deleted the issue-17190 branch January 4, 2016 16:51
@fabpot fabpot mentioned this pull request Jan 14, 2016
@fabpot fabpot mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants