[Process] Fix potential race condition #17276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fix-race
branch
from
41c0554
to
dc9db75
Compare
| $timeout = 0.1; | ||
| $process = $this->getProcess(self::$phpBin.' -r "sleep(1);"'); | ||
| $process->setTimeout($timeout); | ||
| $process = $this->getProcess(self::$phpBin.' -r "sleep(30);"'); |
There was a problem hiding this comment.
this fixes a transient test
nicolas-grekas
force-pushed
the
fix-race
branch
17 times, most recently
from
bcf4ad3
to
1768a92
Compare
nicolas-grekas
force-pushed
the
fix-race
branch
from
1768a92
to
b114a85
Compare
|
Looks good, I triggered a bunch of builds without any failure so far |
|
looks good to me. 👍 |
|
LGTM 👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [Process] Fix potential race condition | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As seen at https://travis-ci.org/symfony/symfony/jobs/100448880#L2768, ProcessTest::testRunProcessWithTimeout can create an infinite blocking situation. I found two potential code paths that could be subject to a race condition. This fixes them. Commits ------- b114a85 [Process] Fix potential race condition
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen at https://travis-ci.org/symfony/symfony/jobs/100448880#L2768, ProcessTest::testRunProcessWithTimeout can create an infinite blocking situation.
I found two potential code paths that could be subject to a race condition. This fixes them.