Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3][FrameworkBundle] Add case in Kernel directory guess for PHPUnit #17278

Merged
merged 1 commit into from Jan 7, 2016

Conversation

tgalopin
Copy link
Member

@tgalopin tgalopin commented Jan 6, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:

  • phpunit -c app
  • phpunit --configuration app
  • phpunit --configuration=app

But it fails with the synthax phpunit -capp, even if PHPUnit supports it. This PR fixes this.

See #17272.

@tgalopin tgalopin changed the title [FrameworkBundle] Add case in Kernel directory guess for PHPUnit [2.3][FrameworkBundle] Add case in Kernel directory guess for PHPUnit Jan 6, 2016
@xabbuh
Copy link
Member

xabbuh commented Jan 6, 2016

👍

@fabpot
Copy link
Member

fabpot commented Jan 7, 2016

Thank you @tgalopin.

@fabpot fabpot merged commit 758fc1d into symfony:2.3 Jan 7, 2016
fabpot added a commit that referenced this pull request Jan 7, 2016
…for PHPUnit (tgalopin)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][FrameworkBundle] Add case in Kernel directory guess for PHPUnit

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

The current automatic guess of the Kernel directory in the context of PHPUnit does work properly using the following commands:

- `phpunit -c app`
- `phpunit --configuration app`
- `phpunit --configuration=app`

But it fails with the synthax `phpunit -capp`, even if PHPUnit supports it. This PR fixes this.

See #17272.

Commits
-------

758fc1d [FrameworkBundle] Add case in Kernel directory guess for PHPUnit
This was referenced Jan 14, 2016
@fabpot fabpot mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants