[FrameworkBundle] Use proper class to fetch $versionStrategy property #17298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $v = new \ReflectionProperty($package, 'versionStrategy'); | ||
| while ('Symfony\Component\Asset\Package' !== $class->getName()) { |
There was a problem hiding this comment.
same comment than in the original PR: why can't we just do $v = new \ReflectionProperty('Symfony\Component\Asset\Package', 'versionStrategy'); instead of the while loop?
There was a problem hiding this comment.
Seems reasonable, I'll try your proposal.
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2016
…gy property (dosten) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #17298). Discussion ---------- [FrameworkBundle] Use proper class to fetch $versionStrategy property | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17259 | License | MIT This is a replacement of #17260 Commits ------- e38fa13 Use proper class to fetch $versionStrategy property
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement of #17260