[Console] Display console application name even when no version set #17326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -324,6 +324,8 @@ public function getLongVersion() | |||
| { | |||
| if ('UNKNOWN' !== $this->getName() && 'UNKNOWN' !== $this->getVersion()) { | |||
| return sprintf('<info>%s</info> version <comment>%s</comment>', $this->getName(), $this->getVersion()); | |||
| } else if ('UNKNOWN' !== $this->getName()) { | |||
|
👍 |
| @@ -325,6 +325,9 @@ public function getLongVersion() | |||
| if ('UNKNOWN' !== $this->getName() && 'UNKNOWN' !== $this->getVersion()) { | |||
| return sprintf('<info>%s</info> version <comment>%s</comment>', $this->getName(), $this->getVersion()); | |||
| } | |||
| if ('UNKNOWN' !== $this->getName()) { | |||
| return sprintf('<info>%s</info>', $this->getName()); | |||
| } | |||
There was a problem hiding this comment.
More clear would be IMO:
if ('UNKNOWN' !== $this->getName()) {
if ('UNKNOWN' !== $this->getVersion()) {
return sprintf('<info>%s</info> version <comment>%s</comment>', $this->getName(), $this->getVersion());
}
return sprintf('<info>%s</info>', $this->getName());
}There was a problem hiding this comment.
It's what I had done at first but I thought I was less clear. Anyway I can change no problems !
|
👍 |
|
Thank you @polc. |
fabpot
added a commit
that referenced
this pull request
Jan 14, 2016
…rsion set (polc) This PR was squashed before being merged into the 2.3 branch (closes #17326). Discussion ---------- [Console] Display console application name even when no version set | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When displaying help of an Application with a name but no version, it show "Console Tool" instead of the application name. Commits ------- 61e810e [Console] Display console application name even when no version set
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying help of an Application with a name but no version, it show "Console Tool" instead of the application name.