Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfiler] Fixed sf-minitoolbar height #17334

Merged
merged 1 commit into from Jan 12, 2016
Merged

[WebProfiler] Fixed sf-minitoolbar height #17334

merged 1 commit into from Jan 12, 2016

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jan 11, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

toolbar-sf-2 8

EDIT: This bug occurs when we use

* {
    box-sizing: border-box;
}

in the stylesheet (TwitterBootstrap for instance)

position: fixed;
right: 0;
z-index: 99999;
box-sizing: border-box;
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefixed versions must be before the standard one, so that the standard version wins over the prefixed one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stof updated!

added box-sizing

Restore padding box (no visual changes)
@fabpot
Copy link
Member

fabpot commented Jan 12, 2016

Thank you @yceruto.

@fabpot fabpot merged commit 9d1e65d into symfony:2.8 Jan 12, 2016
fabpot added a commit that referenced this pull request Jan 12, 2016
This PR was merged into the 2.8 branch.

Discussion
----------

[WebProfiler] Fixed sf-minitoolbar height

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

![toolbar-sf-2 8](https://cloud.githubusercontent.com/assets/2028198/12245117/d293c178-b874-11e5-981b-0ca335a8c3aa.png)

EDIT: This bug occurs when we use
```css
* {
    box-sizing: border-box;
}
```
in the stylesheet (TwitterBootstrap for instance)

Commits
-------

9d1e65d [WebProfiler] Fixed sf-minitoolbar height
@yceruto yceruto deleted the patch-2 branch January 12, 2016 17:27
@fabpot fabpot mentioned this pull request Jan 14, 2016
@fabpot fabpot mentioned this pull request Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants