Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bootstrap form theme form "reset" buttons #17418

Merged
merged 1 commit into from Jan 19, 2016

Conversation

javiereguiluz
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14290
License MIT
Doc PR -

All the credit for this solution goes to @AntonioAmore, who reported the error originally and provided a solution. I only confirmed the bug and verified the proposed solution.

@Tobion
Copy link
Member

Tobion commented Jan 18, 2016

👍

Status: Reviewed

@fabpot
Copy link
Member

fabpot commented Jan 19, 2016

Thank you @javiereguiluz.

@fabpot fabpot merged commit 67c7f05 into symfony:2.7 Jan 19, 2016
fabpot added a commit that referenced this pull request Jan 19, 2016
…iluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Fixed Bootstrap form theme form "reset" buttons

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14290
| License       | MIT
| Doc PR        | -

All the credit for this solution goes to @AntonioAmore, who reported the error originally and provided a solution. I only confirmed the bug and verified the proposed solution.

Commits
-------

67c7f05 Fixed Bootstrap form theme form "reset" buttons
javiereguiluz added a commit to EasyCorp/EasyAdminBundle that referenced this pull request Jan 19, 2016
This PR was merged into the master branch.

Discussion
----------

Improved the form theme for "reset" buttons

This is the same change proposed for the official Symfony form theme: symfony/symfony#17418

Commits
-------

0207732 Improved the form theme for "reset" buttons
@fabpot fabpot mentioned this pull request Feb 3, 2016
This was referenced Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants