[Serializer] Deprecate SerializerAwareEncoder #18483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JhonnyL
commented
Apr 8, 2016
JhonnyL
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -21,8 +23,10 @@ | |||
| * @author Fabian Vogler <fabian@equivalence.ch> | |||
| * @author Kévin Dunglas <dunglas@gmail.com> | |||
| */ | |||
| class XmlEncoder extends SerializerAwareEncoder implements EncoderInterface, DecoderInterface, NormalizationAwareInterface | |||
| class XmlEncoder implements EncoderInterface, DecoderInterface, NormalizationAwareInterface, SerializerAwareInterface | |||
There was a problem hiding this comment.
This is a BC break (in case someone type-hinted with SerializerAwareEncoder).
JhonnyL
force-pushed
the
deprecate-SerializerAwareEncoder
branch
from
a6c3cf8
to
2d09076
Compare
|
@xabbuh I reverted the changes to XmlEncoder. |
|
|
||
| /** | ||
| * SerializerAware Encoder implementation. | ||
| * | ||
| * @author Jordi Boggiano <j.boggiano@seld.be> | ||
| * | ||
| * @deprecated since version 3.1, to be removed in 4.0. Use the SerializerAwareTrait instead. |
There was a problem hiding this comment.
the deprecation warning must be triggered too
There was a problem hiding this comment.
btw, this will be 3.2, not 3.1, as we are already feature-frozen
There was a problem hiding this comment.
But that would trigger a deprecation warning whenever XmlEncoder is used, with no option to fix it.
I will update to 3.2
There was a problem hiding this comment.
@stof Isn't the docblock annotation enough as the rest is handled by the debug class loader?
JhonnyL
force-pushed
the
deprecate-SerializerAwareEncoder
branch
from
67c4c3b
to
af57467
Compare
|
LGTM 👍 |
|
👍 |
|
Thank you @JhonnyL. |
fabpot
added a commit
that referenced
this pull request
Jun 8, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Serializer] Deprecate SerializerAwareEncoder | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- af57467 [Serializer] Deprecate SerializerAwareEncoder
Merged
sandergo90
pushed a commit
to sandergo90/symfony
that referenced
this pull request
Jul 4, 2019
…JhonnyL) This PR was merged into the 3.2-dev branch. Discussion ---------- [Serializer] Deprecate SerializerAwareEncoder | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- af57467 [Serializer] Deprecate SerializerAwareEncoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.