[HttpFoundation][Session] Fix memcache session handler #20375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should pick 2.7 as base branch for bug fixes, as the others are not supported any more. It could then possibly be merged upwards to 2.8, 3.1 and dev-master/3.2-dev |
klandaika
force-pushed
the
fix-memcache-session-handler
branch
from
66d7dcc
to
0423d89
Compare
|
Changed the base to 2.7 as requested. |
|
sounds reasonnable |
|
Thank you @klandaika. |
fabpot
added a commit
that referenced
this pull request
Nov 4, 2016
…andaika) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation][Session] Fix memcache session handler | Q | A | ------------- | --- | Branch? | 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7, 2.8, 3.0, 3.1, master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commit 0216e05 removed the opening of connection to memcached server on call to `open()`, because it's assumed that connection is already opened. However, `close()` still closes the connection. As a result no more read/write calls can be made if session got closed, as the connection does not get reestablished. Basically MemcacheSessionHandler should follow same logic as Memcache**d**SessionHandler, which is exactly what this MR acomplishes. Commits ------- 0423d89 [HttpFoundation][Session] memcached connection should not be closed
|
Do I have to do anything to get this merged up to master? or do you handle that internally? |
|
Nothing to do on your side, we merge old branches into newer ones on a regular basis. Thanks. |
This was referenced Nov 17, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0216e05 removed the opening of connection to memcached server on call to
open(), because it's assumed that connection is already opened. However,close()still closes the connection. As a result no more read/write calls can be made if session got closed, as the connection does not get reestablished.Basically MemcacheSessionHandler should follow same logic as MemcachedSessionHandler, which is exactly what this MR acomplishes.