[Validator] ensure the proper context for nested validations #20664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 28, 2016
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #14639, #20368 |
| License | MIT |
| Doc PR | n/a |
This was referenced Nov 28, 2016
|
A necessary feature since 2.7 is LTS and this bug's really tricky |
ogizanagi
reviewed
Nov 28, 2016
| @@ -110,6 +111,11 @@ public function validate($value, $constraints = null, $groups = null) | |||
| $previousMetadata = $this->context->getMetadata(); | |||
| $previousPath = $this->context->getPropertyPath(); | |||
| $previousGroup = $this->context->getGroup(); | |||
| $previousConstraint = null; | |||
|
|
|||
| if ($this->context instanceof ExecutionContext || method_exists($this->context, 'getConstraint')) { | |||
There was a problem hiding this comment.
Why not just if (method_exists($this->context, 'getConstraint')) ?
There was a problem hiding this comment.
I did not test it, but the instanceof check should be faster and should be true most of the time.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2016
…ns (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [Validator] ensure the proper context for nested validations | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14639, #20368 | License | MIT | Doc PR | n/a Commits ------- 56c8ff8 ensure the proper context for nested validations
Merged
This was referenced Dec 13, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.