[Config] ConfigCache::isFresh() should return false when unserialize() fails #20671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
unser-safe
branch
2 times, most recently
from
36e4ec6
to
65b89c2
Compare
stof
reviewed
Nov 28, 2016
| $meta = unserialize(file_get_contents($metadata)); | ||
| $unserializeCallbackHandler = ini_set('unserialize_callback_func', ''); | ||
| $signalingException = new \UnexpectedValueException(); | ||
| set_error_handler(function () use ($signalingException) { throw $signalingException; }); |
There was a problem hiding this comment.
what about other errors happening there due to bugs in the unserialize implementation of Serializable resources ? They would be completely swallowed currently. Shouldn't we try to detect only the case of undefined classes ?
There was a problem hiding this comment.
updated to return false only when hitting not found classes
nicolas-grekas
force-pushed
the
unser-safe
branch
3 times, most recently
from
c2a5991
to
09132bf
Compare
nicolas-grekas
force-pushed
the
unser-safe
branch
from
09132bf
to
609245e
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2016
…nserialize() fails (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Config] ConfigCache::isFresh() should return false when unserialize() fails | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20654 | License | MIT | Doc PR | - Removes some `Warning: Class __PHP_Incomplete_Class has no unserializer` failures when clearing the cache. Commits ------- 609245e [Config] ConfigCache::isFresh() should return false on __PHP_Incomplete_Class
Merged
This was referenced Dec 13, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some
Warning: Class __PHP_Incomplete_Class has no unserializerfailures when clearing the cache.